Fix: Added notify and drawer default CSS animations #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
commented
Oct 30, 2024
less/core/drawer.less
Outdated
| @@ -22,7 +22,7 @@ | |||
| } | |||
|
|
|||
| .drawer:not(.disable-animation) { | |||
| .transition(left @duration ease-in, right @duration ease-in, transform @duration ease-in, opacity @duration ease-in;); | |||
| .transition(left var(--drawerDuration) @animation-easing, right var(--drawerDuration) @animation-easing, transform var(--drawerDuration) @animation-easing, opacity var(--drawerDuration) @animation-easing;); | |||
There was a problem hiding this comment.
I don't think any of our other variables are camel case or without the --adapt- prefix --adapt-drawer-animation-duration.
What is the @duration property for if not this? Why do we need a differentiating variable for notify animation duration independent of the drawer animation duration?
https://github.com/search?q=repo%3Aadaptlearning%2Fadapt-contrib-vanilla+%40duration&type=code&p=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of adaptlearning/adapt-contrib-core#600
requires adaptlearning/adapt-contrib-core#601
tbc
Fix
Update
New
Breaking